🔁 Modernized index landing page#2413
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Stellar Developer Docs landing page content and layout to a more modern introduction, including an embedded explainer video.
Changes:
- Replace the introductory copy with updated messaging.
- Remove the unused
PathfindingTableimport and add aYouTubeembed to the homepage. - Adjust the “developer docs” description copy (including “on- and off-ramps” wording).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ElliotFriend
left a comment
ElliotFriend
left a comment
There was a problem hiding this comment.
Thanks for this — there are three things in here I definitely want, and two I'm going to decline. Let me be specific so you can trim this to a fast merge.
Keep (please reduce the PR to these):
loading="lazy"on the YouTube component — nice catch, and it now benefits every meeting-note page using the component.- Removing the unused
PathfindingTableimport — confirmed dead on main. - The "on- and off-ramps" hyphenation fix — correct suspended hyphen.
Declining:
- The video embed: homepage content is curated with our DevRel/comms folks, and we're not adding a featured video right now. If you think one belongs there, an issue is the right venue so the right people can weigh in on which video and where.
- The intro prose rewrite: this is a voice call. The current phrasing ("will teach you...") is the tone we want on the landing page, and additions like "for everyone" read more marketing than docs. Keeping the original.
Strip it down to the three keepers and I'll merge it quickly. Thanks!
As an author, passive or intransitive verbs hurt my happiness.
|
Changes made, and I see what you're getting at with the team review. I have only seen a small group of accounts commenting on here for more design-focused issues I opened before. I appreciate and see that there can be more discussion with relevant parties. Namely, it was my interpretation of the Stellar deprecation that it came from a "higher-up" decision authority. Obviously, there wasn't much discussion of the transition on here. I would appreciate having more open development communications and planning debates here as suggested.
The homepage looks good, and I see what you're getting at with the informative tone. But I do dissent because I'd much rather use the active voice so that sentences flow together cohesively. I've seen that infinitive phrasing throughout a lot of the docs and, while I can appreciate its use, I try to introduce a subject and a noun object, as I think we should to prevent confusion like #2398 (comment) (where a cleaner read would've been "Validators [did something].") |
No description provided.